Skip to content

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Oct 1, 2025

Content of this PR:

  • Deprecated jackson 2 support classes
  • Added jackson 3 equivalent classes
  • Copied and translated unit tests (there's still one failing)

Notable changes from Jackson 2:

  • ObjectMapper and JsonFactory are fully immutable in 3.x -> using rebuild() to allow customization of user configured mapper
  • Using the specialized JsonMapper instead of ObjectMapper
  • DeserializationFeature.FAIL_ON_TRAILING_TOKENS is now enabled by default, need to disable it in the config
  • JacksonException now is a runtime exception, removed handling

@l-trotta l-trotta marked this pull request as draft October 1, 2025 16:41
@l-trotta l-trotta requested a review from swallez October 1, 2025 16:41
@l-trotta l-trotta mentioned this pull request Oct 1, 2025
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l-trotta l-trotta marked this pull request as ready for review October 21, 2025 10:47
@l-trotta l-trotta merged commit 2364171 into main Oct 21, 2025
11 checks passed
@l-trotta l-trotta deleted the jackson3-support branch October 21, 2025 11:43
github-actions bot pushed a commit that referenced this pull request Oct 21, 2025
* add jackson 3 support

* updated unit tests

* fix test

* removed comment

* deprecate jackson 2 classes

* Catch parsing exceptions to convert them to JsonP's JsonParsingException

* Jackson 3 does work :-)

* cleanup, using stable dependencies

* refactor gradle

* add new jackson bom url

* restore exception wrap behavior

---------

Co-authored-by: Sylvain Wallez <[email protected]>
l-trotta added a commit that referenced this pull request Oct 21, 2025
* add jackson 3 support

* updated unit tests

* fix test

* removed comment

* deprecate jackson 2 classes

* Catch parsing exceptions to convert them to JsonP's JsonParsingException

* Jackson 3 does work :-)

* cleanup, using stable dependencies

* refactor gradle

* add new jackson bom url

* restore exception wrap behavior

---------

Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: Sylvain Wallez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants